Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Onboarding redesign #13146

Merged
merged 188 commits into from
Aug 12, 2022
Merged

feat: Onboarding redesign #13146

merged 188 commits into from
Aug 12, 2022

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Apr 22, 2022 •
edited by Douglashdaniel
Loading

Resolves brave/brave-browser#22591
Fixes: brave/brave-browser#22817

Security review request: https://github.com/brave/security/issues/951

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Prep:

  1. Reset Wallet via wallet settings
  2. Open wallet via top-bar icon
  3. Wallet Onboarding Welcome Panel should appear
  4. Click "Learn more"
  5. The Wallet Onboarding Welcome Tab should open
Screen.Recording.2022-07-07.at.10.58.59.AM.mov

Scenario 1 - Learn More about wallets

  1. Click "Learn more about crypto wallet"
  2. A new tab should open to "https://brave.com/learn/what-is-crypto-wallet/"
Screen.Recording.2022-07-07.at.10.59.54.AM.mov

Scenario 1a - New Wallet

  1. Click "Create a new wallet"
  2. Agree to Terms
  3. Create a password
  4. Click "Got it"
  5. Backup recovery phrase (check that reveal, clipboard and file download works)
  6. Verify recovery phrase
  7. Click Next
  8. Onboarding success screen appears
  9. Click Done
  10. Wallet Portfolio page is opened
Screen.Recording.2022-07-07.at.11.00.54.AM.mov

Scenario 1b - Restore Wallet from recovery phrase

Screen.Recording.2022-07-07.at.11.09.28.AM.mov

Scenario 1c - Import Wallet from MetaMask

Screen.Recording.2022-07-07.at.2.00.46.PM.mov

Scenario 1d - Import Wallet from Legacy Crypto Wallets

Screen.Recording.2022-07-07.at.2.08.18.PM.mov

Scenario 2a - Buy Crypto

Screen.Recording.2022-07-07.at.2.11.48.PM.mov

Scenario 2b - Fund Wallet with Crypto

Screen.Recording.2022-07-07.at.2.13.27.PM.mov

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 22, 2022
@josheleonard josheleonard force-pushed the feat-onboarding-next branch 4 times, most recently from c3e6337 to 803b68e Compare April 25, 2022 17:09
@josheleonard josheleonard marked this pull request as ready for review April 25, 2022 18:25
@josheleonard josheleonard requested a review from a team as a code owner April 25, 2022 18:25
@github-actions github-actions bot added rebase and removed rebase labels Apr 25, 2022
@josheleonard josheleonard marked this pull request as draft April 25, 2022 18:32
@josheleonard josheleonard force-pushed the feat-onboarding-next branch 18 times, most recently from 45f8932 to f8ab96a Compare April 30, 2022 00:46
@josheleonard
fix: disclosures page text alignment
7966d80
@josheleonard
fix: react unrecognized props errors
f9fdc02
@josheleonard
fix: update new password requirements
d72845e 
The only requirement now is a minimum length of 8 characters
@josheleonard
fix: remove unused component props
7e9e94a
@josheleonard
fix: missing hook dependency
ba63599
@josheleonard
fix: validate pasted recovery phrase
e62c986
@josheleonard
fix: remove article from copy text
be2e7ce
@josheleonard
fix: remove article from import button text
035698d
@josheleonard
fix: improve keyboard UX during password creation
16e8288 
Fixed show/hide icon not displaying focus indication styles when focused

Removed the show/hide icon from the password confirmation field

Refactored PasswordInput to allow rendering child components
@josheleonard
fix: use selected currency for buy-assets url
115af19
@josheleonard
fix: remove recovery phrase save-to-file button
0e84086
@josheleonard
chore: explain why password reqs changed
fc431a3
@josheleonard
fix: remove unused locale strings
879c120
@josheleonard
fix: prevent checkbox event when clicking TOU link
0d3c986
@josheleonard
fix: add autoComplete=off to recovery phrase input
5e35075
@josheleonard
fix: prevent multiple wallets during onboarding
b52ffc1
@josheleonard
fix: show gas tokens and BAT first in buy list
8228c4a
@josheleonard
fix: broken locale string
fd20761
@josheleonard
fix: redefine weak, medium & strong passwords
0d7396c 
length of 8=weak, 12=medium 16=strong
@josheleonard
fix: do not use textarea to display seed phrase
4883bbf
@josheleonard
fix: hide sorting filter on deposit & fund screens
aa23bd9
@josheleonard
fix: delay rendering token list on deposit screen
dcc27c8
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard merged commit 8c970d8 into master Aug 12, 2022
@josheleonard josheleonard deleted the feat-onboarding-next branch August 12, 2022 19:48
@josheleonard josheleonard mentioned this pull request Aug 15, 2022
Closed
@spylogsster
Copy link
Contributor

This PR reintroduces the session state bug where the seed gets stored in the session file. The mitigation that was used to fix this last time was to use autocomplete="off". See this commit for an example.

Session file stores seed in plaintext Session file stores seed in plaintext

https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1661367744020979 Fix for sessions has been uplifted, cc @bsclifton @kdenhartog

@srirambv srirambv mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

@thypon thypon thypon approved these changes

@onyb onyb Awaiting requested review from onyb

@muliswilliam muliswilliam Awaiting requested review from muliswilliam

@supermassive supermassive Awaiting requested review from supermassive

Assignees

@josheleonard josheleonard

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging this pull request may close these issues.

Wallet is using an obsolete password policy Wallet onboarding redesign
8 participants
@josheleonard @brave-builds @muliswilliam @kdenhartog @spylogsster @supermassive @thypon @Douglashdaniel